[PATCH] D131270: MC: make section classification a bit more thorough

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 22:28:00 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:571
+    // FIXME: should we differentiate between SHT_PROGBITS and SHT_NOBITS?
+    Kind = SectionKind::getThreadData();
+  else if (CachedName.startswith(".debug_"))
----------------
Better to fix the distinction for .tdata (SHT_PROGBITS) and .tbss (SHT_NOBITS)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131270/new/

https://reviews.llvm.org/D131270



More information about the llvm-commits mailing list