[PATCH] D132511: [AMDGPU] Detect uniformness of TID / wavefrontsize

[Brendon Cahoon via Phabricator via llvm-commits]

bcahoon added a comment.

This looks good to me. The patch enables the compiler to generate s_load when the user writes code that divides threadIdx.x by the wavefront size. The only suggestion I have is to add some test cases showing explicitly that the amdgpu.uniform metadata is added via the divergence analysis. (by the AnnotateUniformValues pass). The test cases provided rely upon that working correctly, though they show the end result rather than the steps needed to get the result.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132511/new/

https://reviews.llvm.org/D132511