[PATCH] D64831: [Xtensa 5/10] Add Xtensa MCTargetDescr initial functionality.

[Andrei Safronov via Phabricator via llvm-commits]

andreisfr marked an inline comment as done.
andreisfr added inline comments.


================
Comment at: llvm/lib/Target/Xtensa/MCTargetDesc/XtensaAsmBackend.cpp:105
+  case 2:
+    OS.write("\0\0", 2);
+    break;
----------------
saugustine wrote:
> I would use the nop.n encoding here (0xF03D). Then on density machines, the only situation with an invalid instruction is the single-byte case. Although bonus points for a little bit of math to make every case but the single-byte case work--that would be best.
Corrected


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64831/new/

https://reviews.llvm.org/D64831