[PATCH] D132625: [RISCV][test][NFC] Update branch-relaxation.ll with update_llc_test_checks.py

[Piggy via Phabricator via llvm-commits]

piggynl created this revision.
piggynl added reviewers: luismarques, StephenFan.
Herald added subscribers: sunshaoce, VincentWu, luke957, vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, asb, arichardson.
Herald added a project: All.
piggynl requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD, MaskRay.
Herald added a project: LLVM.

Update `llvm/test/CodeGen/RISCV/branch-relaxation.ll` with `update_llc_test_checks.py`, according to https://reviews.llvm.org/D130560#3746417:

In D130560#3746417 <https://reviews.llvm.org/D130560#3746417>, @luismarques wrote:

> In D130560#3746379 <https://reviews.llvm.org/D130560#3746379>, @luismarques wrote:
>
>> The tests don't seem to have been properly updated with `update_llc_test_checks.py`. `llvm/test/CodeGen/RISCV/branch-relaxation.ll` contains RV64 RUN lines but the corresponding CHECK lines are missing in some functions.
>
> Looking more closely at this, I guess you tried to only include the `CHECK-RV64` and `CHECK-RV32` checks when relevant. That's a good instinct but I guess it goes a bit against how we normally use `update_llc_test_checks.py`. My understanding of the trade-off of using that tool is that the test updates are much easier, even if sometimes the CHECKs aren't as tight as something more tailormade.




Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132625

Files:
  llvm/test/CodeGen/RISCV/branch-relaxation.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132625.455436.patch
Type: text/x-patch
Size: 66488 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220825/f5d9e09b/attachment.bin>