[PATCH] D64833: [Xtensa 7/10] Add Xtensa instruction printer.

[Sterling Augustine via Phabricator via llvm-commits]

saugustine added inline comments.


================
Comment at: llvm/test/MC/Xtensa/xtensa-invalid.s:13
+# CHECK:      error: expected immediate in range [-128, 127]
+
+# imm8_sh8
----------------
It would be good to check instruction arguments out of order, and invalid register names.


================
Comment at: llvm/test/MC/Xtensa/xtensa-valid.s:4
+
+
+.align	4
----------------
It would be good here to comments marking which instruction formats  (RRR, RRI4, RRI8 and so on). re covered, as the difference between them is a common source of bugs. Perhaps next to one of the instructions.

I assume that eventually there will be comprehensive coverage of all the different formats.





================
Comment at: llvm/test/MC/Xtensa/xtensa-valid.s:61
+# CHECK: encoding: [0x40,0x23,0x83]
+moveqz  a2,a3,a4
+# CHECK-INST: movgez  a3, a11, a12
----------------
Spaces after the commas in this file is inconsistent.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64833/new/

https://reviews.llvm.org/D64833