[PATCH] D132603: [SLP][NFC] Refactor SLPVectorizerPass::vectorizeRootInstruction method.

[Valeriy Dmitriev via Phabricator via llvm-commits]

vdmitrie marked 2 inline comments as done.
vdmitrie added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Vectorize/SLPVectorizer.h:123
+  bool
+  vectorizeRootInstruction(PHINode *P, Value *V, BasicBlock *BB,
+                           slpvectorizer::BoUpSLP &R, TargetTransformInfo *TTI,
----------------
vporpo wrote:
> Nit: This function does the actual work, so we should probably use different names for this and for the one below. Perhaps `vectorizeRootInstructionImpl` ?
To be honest I'm not a big fan of such naming for methods (unless it really necessary).
If you do not insist on the change I'd keep both using same name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132603/new/

https://reviews.llvm.org/D132603