[PATCH] D132603: [SLP][NFC] Refactor SLPVectorizerPass::vectorizeRootInstruction method.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 14:01:48 PDT 2022


ABataev added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:11801-11802
+  for (Value *Op : PostponedInsts)
+    if (auto *Inst = dyn_cast<Instruction>(Op))
+      if (!R.isDeleted(Inst))
+        Res |= tryToVectorize(Inst, R);
----------------
vdmitrie wrote:
> ABataev wrote:
> > It can be merged:
> > ```
> > if (auto *Inst = dyn_cast<Instruction>(Op); Inst && !R.isDeleted(Inst))
> > ```
> I'll make this cleanup in the main patch during outlining. Is that okay with you?
Can you outline this code in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132603/new/

https://reviews.llvm.org/D132603



More information about the llvm-commits mailing list