[PATCH] D132508: [MC] Omit fill value if it's zero when emitting code alignment

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1463
+    OS << ", " << truncateToSize(Value.value(), ValueSize);
+  else
+    OS << ", ";
----------------
`else if (MaxBytesToEmit)`?


================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:1473
+                                         unsigned MaxBytesToEmit) {
+  emitAlignmentDirective(ByteAlignment, Value, ValueSize, MaxBytesToEmit);
+}
----------------
If I'm understand correctly, this is actually a visible change to emitValueToAlignment: it will always explicitly emit the value, even if it's zero.  That's probably what we want (reducing ambiguity in our asm output seems like an improvement), but we should have test coverage for the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132508/new/

https://reviews.llvm.org/D132508