[PATCH] D132204: [RISCV] Generate correct ELF abi flag when empty .ll file has target-abi attribute

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 11:56:52 PDT 2022


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks!



================
Comment at: llvm/test/CodeGen/RISCV/module-target-abi3.ll:1
+; RUN: llc -mtriple=riscv32 -filetype=obj < %s | llvm-readelf -h - | FileCheck -check-prefixes=FLAGS %s
+
----------------
Nit: if this test file is just going to contain the flags check for the foreseeable future then there's not much point in overriding the CHECK prefix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132204/new/

https://reviews.llvm.org/D132204



More information about the llvm-commits mailing list