[PATCH] D132517: [AArch64][DAGCombine] Fix a bug in performBuildVectorCombine where it could produce an invalid EXTRACT_SUBVECTOR

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 09:46:46 PDT 2022


paulwalker-arm added a comment.

A test would be nice but otherwise the patch looks good.  FYI: I didn't realise this requirement existed for fixed length vectors and it seems `SelectionDAG::getNode()` is missing the relevant asserts.  However, when I add them I'm seeing only non-aarch64 failures, so I'm not going to open that can of worms just yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132517/new/

https://reviews.llvm.org/D132517



More information about the llvm-commits mailing list