[PATCH] D131982: [llvm-objdump] Complete -chained_fixups support

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 09:14:30 PDT 2022


thakis accepted this revision.
thakis added a comment.

Please land :)



================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:4996
+  // We use bit manipulation to extract data from the bitfields. This is correct
+  // for both LE and BE hosts, but we assume that the object is little-endian.
+  if (!isLittleEndian())
----------------
(As discussed elsewhere, I think this is the worst of the approaches discussed above, but it's also not terribly important, so fine.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131982/new/

https://reviews.llvm.org/D131982



More information about the llvm-commits mailing list