[PATCH] D132508: [MC] Let assembler decide the fill value for p2align instead of 0x0

[Stephen Long via Phabricator via llvm-commits]

steplong updated this revision to Diff 455245.
steplong added a comment.

- Update text fill value to nop instruction for AArch64
- Still need to set ValueSize arg to 4 for AArch64


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132508/new/

https://reviews.llvm.org/D132508

Files:
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp


Index: llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
===================================================================
--- llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
+++ llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCAsmInfo.cpp
@@ -48,6 +48,8 @@
   UseDataRegionDirectives = true;
 
   ExceptionsType = ExceptionHandling::DwarfCFI;
+
+  TextAlignFillValue = 0xd503201f;
 }
 
 const MCExpr *AArch64MCAsmInfoDarwin::getExprForPersonalitySymbol(
@@ -97,6 +99,8 @@
   ExceptionsType = ExceptionHandling::DwarfCFI;
 
   HasIdentDirective = true;
+
+  TextAlignFillValue = 0xd503201f;
 }
 
 AArch64MCAsmInfoMicrosoftCOFF::AArch64MCAsmInfoMicrosoftCOFF() {
@@ -114,6 +118,8 @@
   CommentString = "//";
   ExceptionsType = ExceptionHandling::WinEH;
   WinEHEncodingType = WinEH::EncodingType::Itanium;
+
+  TextAlignFillValue = 0xd503201f;
 }
 
 AArch64MCAsmInfoGNUCOFF::AArch64MCAsmInfoGNUCOFF() {
@@ -131,4 +137,6 @@
   CommentString = "//";
   ExceptionsType = ExceptionHandling::WinEH;
   WinEHEncodingType = WinEH::EncodingType::Itanium;
+
+  TextAlignFillValue = 0xd503201f;
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132508.455245.patch
Type: text/x-patch
Size: 1105 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220824/7df4b43d/attachment.bin>