[PATCH] D132390: [MCContext] reverse order of DebugPrefixMap sort

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 08:41:58 PDT 2022


MaskRay added inline comments.


================
Comment at: llvm/test/MC/ELF/debug-prefix-map.s:1
-# RUN: rm -rf %t.foo && mkdir %t.foo && cd %t.foo
-# RUN: cp %s %t.foo/src.s
+# RUN: rm -rf %t.foo && mkdir %t.foo && mkdir %t.foo/bar && cd %t.foo
+# RUN: cp %s %t.foo/src.s && cp %s %t.foo/bar/src.s
----------------
dankm wrote:
> MaskRay wrote:
> > mkdir -p %t.foo/bar
> I thought about that, but I also think doing it separately makes it more clear to readers that both paths will be used.
You may keep em, then it should still be clear


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132390/new/

https://reviews.llvm.org/D132390



More information about the llvm-commits mailing list