[PATCH] D131247: [ELF] Parallelize writes of different OutputSections

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

> Thanks. Do you think a smaller task size like 1MiB / 2MiB work fine?

@MaskRay, I did briefly experiment with smaller task sizes and both 1MiB & 2MiB showed similar results on my 2 test PCs with Windows. The performance related issue on Windows occurred when the "task size" was too large and 4MiB appeared to be the "sweet spot" in my testing. If 1MiB or 2MiB can be shown to be beneficial for other platforms, then it should be fine for Windows too (at least in my testing).

> LGTM for the benefits on other targets.

@peter.smith, thanks for testing on Apple M1 <https://reviews.llvm.org/M1>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131247/new/

https://reviews.llvm.org/D131247