[PATCH] D132528: [RISCV] Don't outline pcrel-lo operand.

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 06:08:12 PDT 2022


luismarques accepted this revision.
luismarques added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks Kito, I didn't realize that D123265 <https://reviews.llvm.org/D123265> would have this interaction.



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1357
 
+    // pcrel-high and pcrel-lo can't put in seperated sections, filter that out
+    // if any possible.
----------------
Nit: "seperated" -> "separate". Also, "pcrel-high"-> "pcrel_hi", "pcrel-lo" -> "pcrel_lo".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132528/new/

https://reviews.llvm.org/D132528



More information about the llvm-commits mailing list