[PATCH] D131309: [ELF] Add ability to get a symbol by name from the hash table section

Joseph Huber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 24 04:55:42 PDT 2022


jhuber6 added a comment.

In D131309#3744828 <https://reviews.llvm.org/D131309#3744828>, @jhenderson wrote:

> LGTM, from my point of view, but I note a couple of @MaskRay's comments seem to not have been addressed. Please wait for him to confirm he is happy.

The only one I didn't address was using `substr` because we don't know the size I rely on the `const char *` being implicitly converted to a `StringRef` again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131309/new/

https://reviews.llvm.org/D131309



More information about the llvm-commits mailing list