[PATCH] D132520: [X86] Promote i8/i16 CTTZ (BSF) instructions and remove speculation branch

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp:696
+// FIXME: These should really use the type parameter.
+bool AMDGPUTargetLowering::isCheapToSpeculateCttz(Type *Ty) const {
   return true;
----------------
RKSimon wrote:
> @foad @arsenm Is the Type arg enough for the target to make a better decision on when to speculate cttz/ctlz?
I don't think we need to do any more work here. The hook should always return true for AMDGPU and you can delete the FIXME comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132520/new/

https://reviews.llvm.org/D132520