[PATCH] D131254: [AMDGPU][GISel] Enable Selection of ADD3 for G_PTR_ADD

[Pierre van Houtryve via Phabricator via llvm-commits]

Pierre-vh added a comment.

Apologies for the silly whitespace issue, I was using a new editor while waiting for my workstation to arrive and forgot to enable trailing whitespace trimming.
For the build issue, I was only building the AMDGPU backend so that's a silly mistake too. I'll make sure to check all backends in the future when I make changes like this.

As for

> (ptradd a, (add, b, c)) as well as (ptradd (ptradd a, b), c) ?

I think @arsenm had some thoughts on the former (we should canonicalize one way or the other). The latter should fold with those patterns though, no?

  def : ThreeOp_Pats <ptradd, ptradd, V_ADD3_U32_e64, [p3, i32, i32]>;
  def : ThreeOp_Pats <ptradd, ptradd, V_ADD3_U32_e64, [p5, i32, i32]>;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131254/new/

https://reviews.llvm.org/D131254