[PATCH] D132145: AMDGPU/MetaData: Restrict address space key to only be emitted for "global_buffer" and "dynamic_shared_pointer"

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUHSAMetadataStreamer.cpp:771
     if (auto Qualifier = getAddressSpaceQualifier(PtrTy->getAddressSpace()))
-      Arg[".address_space"] = Arg.getDocument()->getNode(*Qualifier, /*Copy=*/true);
+      // Limiting address space to emit only for a certain ValueKind.
+      if (ValueKind == "global_buffer" || ValueKind == "dynamic_shared_pointer")
----------------
Comment seems redundant (see https://llvm.org/docs/CodingStandards.html#commenting).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132145/new/

https://reviews.llvm.org/D132145