[PATCH] D132376: [BOLT][AArch64] Handle external references to the middle of Constant Islands

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:399
+      else
+        --IslandIter;
+    }
----------------
treapster wrote:
> yota9 wrote:
> > treapster wrote:
> > > yota9 wrote:
> > > > 
> > > It should be  `IslandIter = std::prev(IslandIter)` or `std::advance(IslandIter, -1)`, but i think there's no need to be verbose here. Why not leave it as a decrement?
> > Yes, I meant that. Because of the standard https://en.cppreference.com/w/cpp/iterator/prev checkout Note section.
> I know that, bit IslandIter is not an rvalue
You're right, for some reason I was sure that it was telling about operation on the it == end(), not the end() itself.. NMW


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132376/new/

https://reviews.llvm.org/D132376