[PATCH] D132530: [RISCV] Replace deprecated R_RISCV_CALL with R_RISCV_CALL_PLT

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 22:02:07 PDT 2022


MaskRay created this revision.
MaskRay added reviewers: asb, jrtc27, kito.cheng, lewis-revill.
Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar, hiraditya, arichardson.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added subscribers: llvm-commits, pcwang-thead, eopXD.
Herald added a project: LLVM.

R_RISCV_CALL/R_RISCV_CALL_PLT distinction isn't necessary R_RISCV_CALL has been
deprecated as a resolution to
https://github.com/riscv-non-isa/riscv-elf-psabi-doc/issues/98 .

ld.lld and mold treat the two relocation types the same. GNU ld has a custom
handling for undefined weak functions which is unnecessary: calling an
unresolved undefined weak function is UB and GNU ld can handle the case without
a relocation error (such a function call is usually guarded by a zero value
check and should be allowed).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D132530

Files:
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
  llvm/lib/Target/RISCV/RISCVISelLowering.cpp
  llvm/lib/Target/RISCV/RISCVInstrInfo.cpp
  llvm/lib/Target/RISCV/RISCVMCInstLower.cpp
  llvm/test/CodeGen/RISCV/branch-relaxation.ll
  llvm/test/CodeGen/RISCV/live-sp.mir
  llvm/test/CodeGen/RISCV/make-compressible.mir
  llvm/test/CodeGen/RISCV/mir-target-flags.ll
  llvm/test/CodeGen/RISCV/out-of-reach-emergency-slot.mir
  llvm/test/CodeGen/RISCV/rvv/addi-rvv-stack-object.mir
  llvm/test/CodeGen/RISCV/rvv/fixed-vectors-emergency-slot.mir
  llvm/test/CodeGen/RISCV/rvv/large-rvv-stack-size.mir
  llvm/test/CodeGen/RISCV/rvv/rvv-stack-align.mir
  llvm/test/CodeGen/RISCV/rvv/wrong-stack-offset-for-rvv-object.mir
  llvm/test/CodeGen/RISCV/vector-abi.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132530.455072.patch
Type: text/x-patch
Size: 22331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220824/ec055c8b/attachment-0001.bin>


More information about the llvm-commits mailing list