[PATCH] D132528: [RISCV] Don't outline pcrel-lo operand.

Wang Pengcheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 21:34:00 PDT 2022


pcwang-thead added a comment.

I met similar problem before when doing random testing via csmith, but I didn't  have time to take a deep look. I think it's look great to me and thanks for the fix. :-)



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:1352
+      static_cast<const RISCVTargetMachine &>(MI.getMF()->getTarget());
+  const auto &F = MI.getMF()->getFunction();
   // Make sure the operands don't reference something unsafe.
----------------
Nit: This line can be merged with line 1324, I think.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132528/new/

https://reviews.llvm.org/D132528



More information about the llvm-commits mailing list