[PATCH] D130127: [llvm][TailDuplicator] don't taildup isInlineAsmBrIndirectTargets

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers added inline comments.


================
Comment at: llvm/test/CodeGen/X86/tail-dup-asm-goto.ll:73
+
+define void @ceph_con_v2_try_read(i32 %__trans_tmp_3.sroa.0.0.copyload, i1 %tobool.not.i.i) nounwind {
+  ; CHECK-LABEL: name: ceph_con_v2_try_read
----------------
nickdesaulniers wrote:
> I should test that this crashes prior to my change, since the reproducer was found on ppc, though I don't think the issue is target specific.  If so, I will pre-commit the additional test, and rebase this so we can better see the resulting changes to the test.
Cool; yeah, after I rebase I should add `-verify-machineinstrs` to this test; it now asserts for this addition with the assertion I added recently in D130290.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130127/new/

https://reviews.llvm.org/D130127