[PATCH] D130830: Don't widen shuffle element with AVX512
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 23 16:00:09 PDT 2022
RKSimon added a comment.
Sorry - I lost track of this patch - have we committed test coverage for the regression mentioned on D129537 <https://reviews.llvm.org/D129537>?
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:16860
+ // undef:v16i16
+ if (CrossLaneMask == Mask || InLaneMask == Mask)
+ return SDValue();
----------------
LuoYuanke wrote:
> If `CrossLaneMask == Mask`, `InLaneMask` must be identity mask. However I'm not sure if `InLaneMask == Mask` `CrossLaneMask` must be identity mask.
I think this should be OK
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130830/new/
https://reviews.llvm.org/D130830
More information about the llvm-commits
mailing list