[PATCH] D132508: [MC] Let assembler decide the fill value for p2align instead of 0x0
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 23 15:54:55 PDT 2022
efriedma added a comment.
Reinterpreting `Value == 0` to mean the user didn't specify a value is wrong. We should distinguish between "no fill specified" and "fill zero specified". (At least, that's how it should work, as far as I can tell.)
In the "no fill specified" case, we should end up in emitCodeAlignment; we can emit the correct directive from there, instead of throwing away the information.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132508/new/
https://reviews.llvm.org/D132508
More information about the llvm-commits
mailing list