[PATCH] D130164: [LV] Support predicated div/rem operations via safe-divisor select idiom

Tue Aug 23 12:43:27 PDT 2022

fhahn accepted this revision.
fhahn added reviewers: Ayal, gilr.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM. thanks! I am also adding Ayal and Gil, in case they have additional comments, so it would be good to wait a day with committing so they have a chance to chime in.

================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8361
+    // a block, otherwise we'd need to prove speculation safety without explicit
+    // block predication.  If that assumption is ever invalidated, this code needs
+    // updated.
----------------
reames wrote:
> fhahn wrote:
> > Do you know if there's an easy way to assert this here? Seems like something that could be easily missed.
> I don't, and this a pretty prevalent assumption in the code already.  e.g. all predicated store/load handling does the same.
> 
> If anything, I might lean towards removing the comment as it may falsely give the impression the assumption is unique to this code.  
Fair enough!

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130164/new/

https://reviews.llvm.org/D130164