[PATCH] D132417: [GlobalOpt] Bail out on SROA of a Global if a scalable vector type is seen

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 12:31:11 PDT 2022


efriedma added a comment.

Bailing out seems reasonable: we can't actually tell how many bytes a scalable load/store is touching, so the normal SRA algorithm won't work.  Maybe more intuitive to put the bailout in collectSRATypes().

Not sure why you're sticking the test in llvm/test/CodeGen/AArch64 instead of llvm/test/Transforms/GlobalOpt/.  (If you need TargetTransformInfo, you can make a subfolder llvm/test/Transforms/GlobalOpt/AArch64, but I suspect you don't.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132417/new/

https://reviews.llvm.org/D132417



More information about the llvm-commits mailing list