[PATCH] D131142: [InstCombine] Canonicalize "and, add", "or, add", "xor, add"

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/add.ll:726
 
 ; If all bits affected by the add are included
 ; in the mask, do the add before the mask op.
----------------
bcl5980 wrote:
> I think this code want to get better address pattern for load/store. But don't know why we do this before with this comment.
> @spatel this test case is commited on dab8515370c7fd43782e72c46333e801454219cc
> do you remember the history about the test ?
I didn't find any direct reason, but f82c55fa082711f520 inverted the transform and updated the comment. This patch needs to be rebased, so we are not confusing the diffs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131142/new/

https://reviews.llvm.org/D131142