[PATCH] D131142: [InstCombine] Canonicalize "and, add", "or, add", "xor, add"

chenglin.bi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 09:59:55 PDT 2022


bcl5980 added a comment.

We need to keep nsw/nuw for add I think. 
And it's better to provider alive proof link also.



================
Comment at: llvm/test/Transforms/InstCombine/add.ll:726
 
 ; If all bits affected by the add are included
 ; in the mask, do the add before the mask op.
----------------
I think this code want to get better address pattern for load/store. But don't know why we do this before with this comment.
@spatel this test case is commited on dab8515370c7fd43782e72c46333e801454219cc
do you remember the history about the test ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131142/new/

https://reviews.llvm.org/D131142



More information about the llvm-commits mailing list