[PATCH] D132477: Improve cost model for some 128-bit vector operations that use SVE

[Hassnaa Hamdi via Phabricator via llvm-commits]

hassnaa-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2044
       // expanded into scalar divisions of each pair of elements.
-      Cost += getArithmeticInstrCost(Instruction::ExtractElement, Ty, CostKind,
-                                     Op1Info, Op2Info);
-      Cost += getArithmeticInstrCost(Instruction::InsertElement, Ty, CostKind,
-                                     Op1Info, Op2Info);
+      if (OverrideNEON || (isa<ScalableVectorType>(Ty))) {
+        bool IsFloat = Ty->isFPOrFPVectorTy();
----------------
@sdesmalen 
I noticed something here,
is using that **isa** for Ty is correct, give that Ty is a ptr of "Type" ?
I thought about using Ty.isVectorTy(), but it returns true for both scalable and fixed vectors, so it doesn't work here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132477/new/

https://reviews.llvm.org/D132477