[PATCH] D132411: [libcxxabi] Unbreak `LLVM_ENABLE_PROJECTS=libcxxabi` build

[Kadir Cetinkaya via Phabricator via llvm-commits]

kadircet added inline comments.


================
Comment at: libcxxabi/CMakeLists.txt:136
     "Specify path to libc++ includes.")
-if (NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
+if ((NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES) AND (NOT libcxx IN_LIST LLVM_ENABLE_PROJECTS))
   if (NOT IS_DIRECTORY ${LIBCXXABI_LIBCXX_INCLUDES})
----------------
i think we should have a fixme here (and in the relevant test) to drop the check for PROJECTS once libcxx/abi can't be built through it.


================
Comment at: libcxxabi/test/CMakeLists.txt:64
 
-if(libcxx IN_LIST LLVM_ENABLE_RUNTIMES)
+if ((NOT libcxx IN_LIST LLVM_ENABLE_RUNTIMES) AND (NOT libcxx IN_LIST LLVM_ENABLE_PROJECTS))
   list(APPEND LIBCXXABI_TEST_DEPS cxx)
----------------
isn't the first `NOT` here, before `libcxx` is wrong? (same for below)

i think we want `libcxx` to be present in RUNTIMES but not in PROJECTS.


================
Comment at: llvm/CMakeLists.txt:112
 # one for llvm+clang+... using the same sources.
 set(LLVM_ALL_PROJECTS "bolt;clang;clang-tools-extra;compiler-rt;cross-project-tests;libc;libclc;libcxx;libcxxabi;libunwind;lld;lldb;mlir;openmp;polly;pstl")
 # The flang project is not yet part of "all" projects (see C++ requirements)
----------------
should we also drop `libcxx(abi)` from this list? probably as a follow up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132411/new/

https://reviews.llvm.org/D132411