[PATCH] D132447: AMDGPU: Add a pass to fix SGPR liveness

[Carl Ritson via Phabricator via llvm-commits]

critson added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRLiveness.cpp:88
+      SmallVector<std::pair<MachineOperand *, MachineBasicBlock *>, 4> Undefs;
+      // Register SingleValue = AMDGPU::NoRegister;
+      MachineOperand *SingleOp = nullptr;
----------------
Stray comment?


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRLiveness.cpp:93
+        MachineOperand *SrcOp = &MI.getOperand(i);
+        if (!SrcOp->isReg() || !SrcOp->getReg().isVirtual())
+          continue;
----------------
Do these influence SingleOp?


================
Comment at: llvm/lib/Target/AMDGPU/SIFixSGPRLiveness.cpp:127
+      }
+      continue;
+    }
----------------
Unnecessary continue?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132447/new/

https://reviews.llvm.org/D132447