[PATCH] D132387: [runtimes] Handle interface targets in runtimes distribution components

[Louis Dionne via Phabricator via llvm-commits]

ldionne accepted this revision as: libc++.
ldionne added a comment.

In D132387#3741080 <https://reviews.llvm.org/D132387#3741080>, @JamesNagurne wrote:

> Hey thanks for looking into this @ldionne
>
> Maybe I'm missing some scope here (I'm very much not an expert on LLVMDistributionSupport), but is the intent here that not every component has a build, but every component should have an install (that may depend on a build, but also might not)?
>
> If that's the case, then this looks good, and is a fairly simple and elegant solution, as opposed to my force-a-build-target solution I'm doing downstream at the moment.

Yeah, basically, I see build targets as being implementation details of the build. What folks should really care about is having correct dependencies between `install-FOO` targets. If you build `install-cxx-headers`, then *that* needs to do the right thing, but who cares whether `cxx-headers` even exists? The fact that it's an interface (or not) target should not matter. This patch attempts to implement that point of view.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132387/new/

https://reviews.llvm.org/D132387