[PATCH] D132449: StructurizeCFG: prefer reduced number of live values

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/CodeGen/AMDGPU/loop_break.ll:49
+; GCN-NEXT:    s_cbranch_scc0 .LBB0_3
+; GCN-NEXT:  ; %bb.2: ; in Loop: Header=BB0_1 Depth=1
+; GCN-NEXT:    ; implicit-def: $sgpr6
----------------
Not your fault, but bb.2 really should have been removed because it only contains an implicit def which does not generate any code.


================
Comment at: llvm/test/CodeGen/AMDGPU/nested-loop-conditions.ll:27
 ; GCN-NEXT:    ; =>This Inner Loop Header: Depth=1
-; GCN-NEXT:    s_mov_b64 s[4:5], -1
-; GCN-NEXT:    s_mov_b64 vcc, s[2:3]
-; GCN-NEXT:    s_cbranch_vccz .LBB0_1
+; GCN-NEXT:    s_cmp_lg_u32 0, 1
+; GCN-NEXT:    s_mov_b64 s[0:1], -1
----------------
Not your fault, but this comparison really should be simplified to "true".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132449/new/

https://reviews.llvm.org/D132449