[PATCH] D132364: [llvm-size] Fix missing file name for darwin output format with non-Mach-O

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Thanks for the patch @xgupta. Please could you write a new test (or update an existing one) in the lit testsuite at llvm\test\tools\llvm-size, to make sure this fix is covered by a test.



================
Comment at: llvm/tools/llvm-size/llvm-size.cpp:512-513
+
+    if (!MachO && OutputFormat == darwin)
+      outs() << Obj->getFileName() << "\n";
   }
----------------
I'm not sure this is the right place for this patch. The filenames are usually printed elsewhere, at the call site.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132364/new/

https://reviews.llvm.org/D132364