[PATCH] D132443: [LSR] Fold terminal condition to other IV when possible

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 01:02:48 PDT 2022


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-complicate-add-rec.ll:46
+for.body.preheader:                               ; preds = %entry
+  %add.ptr = getelementptr inbounds ptr, ptr %mark, i64 3
+  br label %for.body
----------------
is this needed?


================
Comment at: llvm/test/Transforms/LoopStrengthReduce/lsr-fold-iv-complicate-add-rec.ll:50
+for.cond.cleanup.loopexit:                        ; preds = %for.body
+  br label %for.cond.cleanup
+
----------------
is this needed? Would be good to try to simplify the test as much as possible. Also, it would be good to add a patch just for the tests and then only include the diff here. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132443/new/

https://reviews.llvm.org/D132443



More information about the llvm-commits mailing list