[PATCH] D132093: [LV][NFC] Modify code comments
LiqinWeng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 22 21:35:06 PDT 2022
This revision was automatically updated to reflect the committed changes.
Closed by commit rGeaa539afa16e: [LV][NFC] Modify code comments (authored by Miss_Grape).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132093/new/
https://reviews.llvm.org/D132093
Files:
llvm/include/llvm/Analysis/TargetTransformInfo.h
llvm/include/llvm/CodeGen/BasicTTIImpl.h
Index: llvm/include/llvm/CodeGen/BasicTTIImpl.h
===================================================================
--- llvm/include/llvm/CodeGen/BasicTTIImpl.h
+++ llvm/include/llvm/CodeGen/BasicTTIImpl.h
@@ -2350,7 +2350,7 @@
Optional<FastMathFlags> FMF,
TTI::TargetCostKind CostKind) {
// Without any native support, this is equivalent to the cost of
- // vecreduce.op(ext).
+ // vecreduce.opcode(ext(Ty A)).
VectorType *ExtTy = VectorType::get(ResTy, Ty);
InstructionCost RedCost =
thisT()->getArithmeticReductionCost(Opcode, ExtTy, FMF, CostKind);
@@ -2365,7 +2365,8 @@
VectorType *Ty,
TTI::TargetCostKind CostKind) {
// Without any native support, this is equivalent to the cost of
- // vecreduce.add(mul(ext, ext)).
+ // vecreduce.add(mul(ext(Ty A), ext(Ty B))) or
+ // vecreduce.add(mul(A, B)).
VectorType *ExtTy = VectorType::get(ResTy, Ty);
InstructionCost RedCost = thisT()->getArithmeticReductionCost(
Instruction::Add, ExtTy, None, CostKind);
Index: llvm/include/llvm/Analysis/TargetTransformInfo.h
===================================================================
--- llvm/include/llvm/Analysis/TargetTransformInfo.h
+++ llvm/include/llvm/Analysis/TargetTransformInfo.h
@@ -1291,7 +1291,7 @@
/// Calculate the cost of an extended reduction pattern, similar to
/// getArithmeticReductionCost of a reduction with an extension.
/// This is the cost of as:
- /// ResTy vecreduce(ext(Ty A)).
+ /// ResTy vecreduce.opcode(ext(Ty A)).
InstructionCost getExtendedReductionCost(
unsigned Opcode, bool IsUnsigned, Type *ResTy, VectorType *Ty,
Optional<FastMathFlags> FMF,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132093.454689.patch
Type: text/x-patch
Size: 1841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220823/a726c2d0/attachment.bin>
More information about the llvm-commits
mailing list