[PATCH] D131224: [objdump] Find debug information with Build ID/debuginfod.
Petr Hosek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Aug 22 19:11:40 PDT 2022
phosek added a comment.
I think that the changes to build ID/debuginfod and llvm-objdump should be split into two patches, since the former is just a refactoring while the latter is a new functionality.
================
Comment at: llvm/lib/Object/BuildID.cpp:1
+#include "llvm/Object/BuildID.h"
+
----------------
This file is missing the copyright header.
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1272-1283
+static bool hasDebugInfo(const ObjectFile &Obj) {
+ // For now, only ELF DWARF sections are checked.
+ if (!Obj.isELF())
+ return true;
+ return any_of(Obj.sections(), [](SectionRef Sec) {
+ Expected<StringRef> Name = Sec.getName();
+ if (Name)
----------------
Could this be added as a method to `ObjectFile`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131224/new/
https://reviews.llvm.org/D131224
More information about the llvm-commits
mailing list