[PATCH] D132371: [DWARFLinker][NFC] Change interface of DWARFLinker to specify accel table kinds explicitly.

[Greg Clayton via Phabricator via llvm-commits]

clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

I am not sure this change makes sense as all of the Apple tables should be included if you have any, and likewise for .debug_pubnames and .debug_pubtypes: you want both or none.



================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:34-37
+  AppleNamespaces,
+  AppleNames,
+  AppleTypes,
+  AppleObjC,
----------------
All of these go together and you never want any of them unless you have all of them. I would keep these as "Apple" as a single entry.


================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinker.h:38-39
+  AppleObjC,
+  PubNames,
+  PubTypes,
+  DebugNames
----------------
I would keep these as "Pub", again, you never want just one of them, you either want both or none.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132371/new/

https://reviews.llvm.org/D132371