[PATCH] D132361: [LLD] [COFF] Fix export directives in object files from -includeoptional

Mon Aug 22 14:08:16 PDT 2022

mstorsjo added a comment.

In D132361#3740753 <https://reviews.llvm.org/D132361#3740753>, @mstorsjo wrote:

> In D132361#3740605 <https://reviews.llvm.org/D132361#3740605>, @mati865 wrote:
>
>> Unfortunately I lack a lot of context here so cannot tell if there are alternative solutions.
>> How expensive (in terms of performance) is calling `updateLinkLoop` that many times?
>
> I think it might cost a little bit - but I think, in rough terms, that we already run it once or more for the bulk of the linking, and this adds mostly one or two more rounds in the end. But I guess it'd be good to get proper numbers for it.

At least for the size of link jobs I have to test with here, with a total runtime of 1241 ms, the main loop iteration doesn't add up to even 1 ms.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132361/new/

https://reviews.llvm.org/D132361