[PATCH] D128177: [DebugInfo][InstrRef][NFC] Represent DbgValues with multiple ops in LDV

Mon Aug 22 11:19:44 PDT 2022

StephenTozer added inline comments.

================
Comment at: llvm/unittests/CodeGen/InstrRefLDVTest.cpp:1811
+  DbgOpID RspPHIInBlk2ID = addValueDbgOp(RspPHIInBlk2);
+  DbgOpID RspPHIInBlk3ID = addValueDbgOp(RspPHIInBlk3);

----------------
StephenTozer wrote:
> kazu wrote:
> > aeubanks wrote:
> > > this patch seems to have added a lot of unused variables that some bots are complaining about, e.g. https://buildkite.com/llvm-project/upstream-bazel/builds/37703#0182c6bb-7631-491a-8b71-3ed8ae1ef7d6
> > > 
> > > could you take a look?
> > I just landed 58ad7555f564fbcd63d8d782f4fb7f6f2d432fe9.
> > 
> Thanks for catching that, was just reverting - I'll take a look at the unused variable warnings now.
I see you've caught those as well - sorry about that!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128177/new/

https://reviews.llvm.org/D128177