[PATCH] D132055: [LoopInterchange][PR57148] Ensure LCSSA form after loop interchnange

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:575
 
+    if (!OuterLoop->isLCSSAForm(*DT))
+      llvm::formLCSSA(*OuterLoop, *DT, LI, SE);
----------------
why not consider innerloop also?


================
Comment at: llvm/lib/Transforms/Scalar/LoopInterchange.cpp:579
            "Inner loop not left in LCSSA form after loop interchange!");
     assert(OuterLoop->isLCSSAForm(*DT) &&
            "Outer loop not left in LCSSA form after loop interchange!");
----------------
can outer loop still be non-lcssa? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132055/new/

https://reviews.llvm.org/D132055