[PATCH] D132122: AArch64 SVE: add sve patterns to make use of predicated smin, umin, smax, and umax instructions, add ll test file for the new patterns

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 07:04:55 PDT 2022


sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

LGTM with nit addressed, thanks @hassnaa-arm!



================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:361
+def AArch64smax_m1 : EitherVSelectOrPassthruPatFrags<int_aarch64_sve_smax, AArch64smax_p>;
+
+def AArch64umax_m1 : EitherVSelectOrPassthruPatFrags<int_aarch64_sve_umax, AArch64umax_p>;
----------------
nit: can you remove the newlines and move these definitions to line 247? (after previous uses of `EitherVSelectOrPassthruPatFrags`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132122/new/

https://reviews.llvm.org/D132122



More information about the llvm-commits mailing list