[PATCH] D132239: [NFC] Regenerating CHECK lines for type-mismatch tests

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 22 03:19:07 PDT 2022


fhahn added inline comments.


================
Comment at: llvm/test/Transforms/LoopLoadElim/type-mismatch.ll:134
+
+define void @f3(i64* noalias %A, i64* noalias %B, i64* noalias %C, i64 %N) {
+; CHECK-LABEL: @f3(
----------------
jolanta.jensen wrote:
> fhahn wrote:
> > Typed pointers are deprecated, is there any reason to add the new test here instead of `llvm/test/Transforms/LoopLoadElim/type-mismatch-opaque-ptr.ll
> > `? I'd expect the typed pointer version of the tests to be removed relatively soon.
> It's purely to make it easier for reviewers of https://reviews.llvm.org/D130233 to see the impact of the change.
right, what I meant is that  the test probably should just be converted/moved to the opaque pointer version of the tests


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132239/new/

https://reviews.llvm.org/D132239



More information about the llvm-commits mailing list