[PATCH] D132343: [InstCombine] Add undef elements support for shrinkFPConstantVector

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp:1676
     auto *CFP = dyn_cast_or_null<ConstantFP>(CV->getAggregateElement(i));
     if (!CFP)
+      continue;
----------------
Not sure Undef or ConstantFP are the only cases (ConstantExpr)? - so continue for Undef but the return nullptr if not ConstantFP ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132343/new/

https://reviews.llvm.org/D132343