[PATCH] D132349: [AArch64][NFC] Merge some common ISD node when setOperationAction

Mon Aug 22 01:57:57 PDT 2022

Jimerlife added a comment.

In D132349#3738804 <https://reviews.llvm.org/D132349#3738804>, @sdesmalen wrote:

> Hi @Jimerlife is there a specific reason why you're refactoring this? This patch may reduce the number of lines of code, but it is arguable whether the new version is more readable or better. Code-refactoring creates merge-problems for people needing to maintain downstream branches, so unless there is a clear benefit to the code it is preferable to keep this to a minimum.

Thanks for your detail explanation. Keep origin form maybe more better.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132349/new/

https://reviews.llvm.org/D132349