[PATCH] D132323: [LoongArch] Port over minimal applyFixup from RISCV

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 21 23:36:24 PDT 2022


xen0n marked an inline comment as done.
xen0n added a comment.

The patch is ready for review.

This may not need a dedicated test case, because before the change most if not all DebugInfo tests fail on native LoongArch builds, and this change (together with the parent change) fixes them.



================
Comment at: llvm/lib/Target/LoongArch/MCTargetDesc/LoongArchAsmBackend.cpp:80-81
+  MCFixupKindInfo Info = getFixupKindInfo(Kind);
+  if (!Value)
+    return; // Doesn't change encoding.
+  // TODO: Apply any target-specific value adjustments.
----------------
SixWeining wrote:
> Can these 2 lines be moved before line-79?
fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132323/new/

https://reviews.llvm.org/D132323



More information about the llvm-commits mailing list