[PATCH] D132332: [ADT] Clarify llvm::bit_cast implementation comment

Joe Loser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 21 09:49:20 PDT 2022


jloser updated this revision to Diff 454324.
jloser retitled this revision from "[ADT] Clarify llvm::bit_cast implementation comments" to "[ADT] Clarify llvm::bit_cast implementation comment".
jloser edited the summary of this revision.
jloser added a comment.

Only mention the C++17 vs C++20 difference - leave the trivially constructible comment alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132332/new/

https://reviews.llvm.org/D132332

Files:
  llvm/include/llvm/ADT/bit.h


Index: llvm/include/llvm/ADT/bit.h
===================================================================
--- llvm/include/llvm/ADT/bit.h
+++ llvm/include/llvm/ADT/bit.h
@@ -20,7 +20,7 @@
 
 namespace llvm {
 
-// This implementation of bit_cast is different from the C++17 one in two ways:
+// This implementation of bit_cast is different from the C++20 one in two ways:
 //  - It isn't constexpr because that requires compiler support.
 //  - It requires trivially-constructible To, to avoid UB in the implementation.
 template <


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D132332.454324.patch
Type: text/x-patch
Size: 529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220821/957d4cf6/attachment.bin>


More information about the llvm-commits mailing list