[PATCH] D132308: [LV] Replace fixed-order cost model with a SK_Splice shuffle

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 21 04:01:12 PDT 2022


RKSimon added a comment.

In D132308#3737485 <https://reviews.llvm.org/D132308#3737485>, @xbolva00 wrote:

>>> existing cost model can drastically under-estimate the correct cost for the shuffle …. and some targets may require additions to the cost-model to correctly account for them.
>
> Hm, sounds like your fix improves some targets and at the same time possibly regresses others?

For now, please can you add a SK_Splice -> SK_PermuteTwoSrc remapping to targets with getShuffleCost that don't recognise SK_Splice?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132308/new/

https://reviews.llvm.org/D132308



More information about the llvm-commits mailing list