[PATCH] D132282: [LoongArch] Override TargetLowering::hasAndNot()

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Aug 20 21:27:38 PDT 2022


xen0n added a comment.

The changes LGTM but the patch title could be a bit more specific. "Override hasAndNot" is "what you have done", but we generally prefer "what you intend to do by making this change" -- description of your intent.

I think a title like "Implement TargetLowering::hasAndNot for more optimization chances" could be better.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132282/new/

https://reviews.llvm.org/D132282



More information about the llvm-commits mailing list